linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.

GNU Affero General Public License v3.0

63 stars 18 forks source link

TW-2042 Update contacts screen ui #2057

Closed KhaledNjim closed 1 month ago

KhaledNjim commented 2 months ago

Ticket

2042

need merge

LInagora design flutter pr

Resolved

Attach screenshots or videos demonstrating the changes

Web:
Android:
IOS:

github-actions[bot] commented 2 months ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2057

hoangdat commented 1 month ago

[x] still not see the screenshot of contacts which load from address book @KhaledNjim

nqhhdev commented 1 month ago

Wrong hint text

Screenshot 2024-10-01 at 12 48 52

nqhhdev commented 1 month ago

Missing padding

Screenshot 2024-10-01 at 12 51 26

KhaledNjim commented 1 month ago

[ ] still not see the screenshot of contacts which load from address book @KhaledNjim

The contacts at the bottom are from my phonebook

2042_phoneBook.webm

nqhhdev commented 1 month ago

Need to move hover style, divider style, selected background to system design

hoangdat commented 1 month ago

please apply also system-design to this PR @KhaledNjim

hoangdat commented 1 month ago

please keep align to this in top. we should not keep it in center because if we have only 2 lines, blink blink will occur

nqhhdev commented 1 month ago

I found issue related text overflowed on iPhone 15

Simulator Screenshot - iPhone 15 - 2024-10-07 at 15 30 30

Screenshot 2024-10-07 at 15 43 35

nqhhdev commented 1 month ago

Height only 79px, pls check it

Screenshot 2024-10-07 at 15 32 53

nqhhdev commented 1 month ago

Missing color when on press

Screenshot 2024-10-07 at 15 39 57

nqhhdev commented 1 month ago

Height only 79px, pls check it

please make sure to run pub get , because i fixed this in linagora-design-flutter

SURE!

nqhhdev commented 1 month ago

Missing hover on web: Contact and Chat list

Screenshot 2024-10-07 at 15 45 17

Screenshot 2024-10-07 at 15 48 19

KhaledNjim commented 1 month ago

Missing hover on web: Contact and Chat list

Hover is grey and selected item is blue

Web

design

nqhhdev commented 1 month ago

Missing hover on web: Contact and Chat list Hover is grey and selected item is blue

I mean missing border !

nqhhdev commented 1 month ago

Pls add PR of linagora-design-flutter lib on this PR

nqhhdev commented 1 month ago

Still missing border radius when hover or on press

Screenshot 2024-10-08 at 10 26 26

nqhhdev commented 1 month ago

How about this case?

For example: my account has 1000 characters, what is happened?

Simulator Screenshot - iPhone 15 - 2024-10-08 at 10 28 03

KhaledNjim commented 1 month ago

How about this case?

For example: my account has 1000 characters, what is happened?

@nqhhdev Fixed

hoangdat commented 1 month ago

Hi @KhaledNjim , please focus on the alignment, bottom text is well align with bottom avatar.

Screenshot 2024-10-08 at 18 15 00

KhaledNjim commented 1 month ago

Hi @KhaledNjim , please focus on the alignment, bottom text is well align with bottom avatar.

Fixed

KhaledNjim commented 1 month ago

Rebased and tested for android and web, LGTM

hoangdat commented 1 month ago

[ ] search result not show item in recent list

https://github.com/user-attachments/assets/ddbfe99e-6fa0-4ccf-9717-bfedd3084c5d