linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.
GNU Affero General Public License v3.0
64 stars 18 forks source link

TW-2066: Fix upload avatar on web #2075

Closed nqhhdev closed 1 month ago

nqhhdev commented 1 month ago

Ticket

Root cause

Solution

Resolved

https://github.com/user-attachments/assets/54029883-c269-4565-8d4d-1af2fb468e8f

https://github.com/user-attachments/assets/557ba7aa-c969-4fb9-ab8b-bd25196d4eff

https://github.com/user-attachments/assets/25c23ef4-aedc-4870-b981-d8256fb44109

github-actions[bot] commented 1 month ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2075

hoangdat commented 1 month ago
dab246 commented 1 month ago

Memory leak

https://github.com/user-attachments/assets/6c54c4cf-6cf3-4fc5-b210-e5fecb8dc1cb

nqhhdev commented 1 month ago
  • [x] Work fine on Chrome

Memory leak

  • I tried changing avatar in profile and found it memory leak when avatar change is successful. IMO, we can fix it in this PR or create new PR to solve it.

    Screen.Recording.2024-10-04.at.13.46.33.online-video-cutter.com.mp4

IMO: Should create a new ticket for improving it because we need grooming for it.

hoangdat commented 1 month ago

no, we should do it directly in this PR. Maybe something wrong in our solution, need to know the root cause at least

KhaledNjim commented 1 month ago

Tested on chrome, some images were not uploaded successfully

https://github.com/user-attachments/assets/ffc077b6-5f70-46e3-8b86-ec8480b4c3cb

nqhhdev commented 1 month ago

Tested on chrome, some images were not uploaded successfully

I just rebased, pls check it again

https://github.com/user-attachments/assets/153a0618-03bc-4873-8582-3bc2f1f69cdc

nqhhdev commented 1 month ago

please rebase

Done