Update en.json - Githubissues

lingua-libre / SignIt

🌻 Lingua Libre SignIt web-browser extension translates selected word in French Sign Language via an elegant pop up so you learn sign language while reading online.

https://addons.mozilla.org/en-US/firefox/addon/lingua-libre-signit/

MIT License

13 stars 13 forks source link

Update en.json #23

Closed jhsoby closed 2 years ago

jhsoby commented 2 years ago

Fix some grammar/spelling:

Change "Medias" to "Media" (media is already plural in English)
Change "interface's language" to "interface language"
Change "desactives" to "deactivates"
Change "integration into Wikipedia" to "integration with Wikipedia"
Change "enlighten" to "highlight"
Change "defition" to "definition" (this fixes #22)

jhsoby commented 2 years ago

Also, I don't really understand the meaning of "Double play normal / slow" – does it mean you speed up or slow down the video? That needs a change too, but I'm not sure what it should be changed to.

hugolpz commented 2 years ago

@jhsoby thanks for this rapid fixes. It's appreciated. "Double play normal / slow" : SignIt display a video of sign language. It's often too rapid for most people. So we have an option to play the video twice, first at normal speed (x1), then at half speed (x0.5). So we have double play, at normal and then at slow (half speed). I await your feedback before to merge your PR.

jhsoby commented 2 years ago

Okay, that's what I thought. If it is just one button to change to faster/slower, I would suggest just labeling it "Play faster/slower".

hugolpz commented 2 years ago

It's not a switch, moving from normal to slow. It's a switch between

Normal
Normal AND THEN slow.

So there is a double play.

jhsoby commented 2 years ago

Ah, okay. Then I suggest something like "Play at normal speed, then at slow speed" if that's not too long.

hugolpz commented 2 years ago

Ok, fixed. f862077a14f375d4bc9cb60386ccbf6bc00eb26a Thanks again. It's great to have this help.