Closed hugolpz closed 8 months ago
Hey man , thanks for consideration. I just had a few more doubts and request to make : Requests :
discord username: kabir3283
Doubts:
That is all , thanks again for consideration
On Fri, 12 Jan 2024 at 00:59, Lopez Hugo @.***> wrote:
Hello @kabir-afk https://github.com/kabir-afk , following your email I'm happy to grant you contributor rights. Few rapid things to know ๐๐ผ
- Please wait a week or two to edit the code, I got some changes waiting to be pushed to github.
- This project is modest and a bit messy, also using manifest v2 and associated obsolete api calls.
- Having React skills, it may be time efficient to resume from scratch, using Manifest v3 boilerplate. See #21 https://github.com/lingua-libre/SignIt/issues/21 section V3 from scratch ?.
โ Reply to this email directly, view it on GitHub https://github.com/lingua-libre/SignIt/issues/49, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5LB5ERPU357LJMMQP3IM2TYOA4R5AVCNFSM6AAAAABBXARKFOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3TONBUGEZTSNQ . You are receiving this because you were mentioned.Message ID: @.***>
Hey man , I apologize in advance , I know you asked me not to edit the code but I've already updated manifest file from V2 to V3 which was under Issue: 21 , I dont think it would interfere with your workflow/the changes you were about to make locally so I gave it a go , opening a PR rn , you can review the changes and merge them whenever you feel like
No prob @kabir-afk . If you go fast you go fast. The feature I'm working on is tiny, I can slow down on deploiement or even rework it.
okkk then, but do you mind reviewing the PR , as well as can you clear my doubt regarding GSoC as mentioned above ? It'll really help me out
@kabir-afk Hello, My apologize this week is heavily loaded on the work side so i'm brain exhausted. Let me try to answer as best as I can.
Expectations: all fine by me, we are volunteers, not on duty. I wanted to convey that the door is open if you want to. Our general idea is to have fun, help positive changes and get new skills as volunteers devs.ยน As for GSoC, see below.
Communication: I just sent you an email with chat chanels to continue more efficient synchroneous discussion
GSoC doubts: Lingualibre has not joined any previous GSoC edition so far. We are interested by GSoC. But in previous years we hadn't the human time resources or knowledge to actually get involved in it. We have to ask Wikimedia staff or volunteers who already participated the GSoC and mentored developers to learn how to do so. cc @Poslovitch .
Manifest v2 to v3: โ
Review and merged. I didn't git pull
nor test run the extension tho.
1: Disclaimer : I'm currently Wikimedian in Residence in Toulouse for training University staff to Wikimedia projects. My github developements on Lingualibre have been and are volunteer.
hey thanks man for all the effort , I'll test run the extension as well when I'm done with all the steps that come under migration. The reason I asked about gsoc ,was because ,under new developers' projects in wikimedia , this project was mentioned as well , along with VideoCutTool and Scribe. See here . So I thought maybe this extension was part of gsoc as well . . . you'll be able to look into it better ig.
Bonjour @kabir-afk , Thank you for your arrival path info. You are the 2n person contacting me for GSoC this January which puzzled me. The page you shared lists Wikimedia coding projects welcoming or in need of new volunteer developpers. Some of these WM projects are also participating GSoC, but not all of them. I added Lingualibre to that list in July. Lingualibre havent participated to GSoC so far.
Thanks for the clarification . . . I'll keep contributing whenever I get the time . . . genuinely
Hello @kabir-afk , following your email I'm happy to grant you contributor rights. Few rapid things to know ๐๐ผ
21 : Being a junior developer handling legacy code, I have the way but I'm struggling to migrate to v3.
V3 from scratch ?
for leads.You have the gist of it. The rest is coding and project management.