search

lingua-libre / SignIt

🌻 Lingua Libre SignIt web-browser extension translates selected word in French Sign Language via an elegant pop up so you learn sign language while reading online.
https://addons.mozilla.org/en-US/firefox/addon/lingua-libre-signit/
MIT License
11 stars 13 forks source link

Selected language in settings resets when changing pages #56

Open pushkar707 opened 3 months ago

pushkar707 commented 3 months ago

Screenshot (21)

Issue: A lot of time the language set by the user for the extension gets reset, this behavior is seen usually when we open a new tab or just navigate through various URLs in the website.

Reproduction: Change the default language of the extension to any language (English in my case), and just use the browser normally, and keep checking the extension popup's language. You will be very quickly able to see the language change.

My System: OS: Windows 11 with WSL (Ubuntu 20.04)

hugolpz commented 3 months ago

@pushkar707 thank for this issue I was not aware of. Settings are stored in some local storage, so I'm a bit surprised. You are not in some Incognito mode which may remove local storages ?

pushkar707 commented 3 months ago

No, I ran the extension in Firefox browser, through "npm run web-ext:test" command

pushkar707 commented 3 months ago

I think this was an issue on my end only, I will confirm it and close this.

hugolpz commented 3 months ago

@pushkar707 , I assigned you this task since you are leading it as well and (finger crossed 🤞🏼 ) it will self-solve.