lingua-libre / SignIt

🌻 Lingua Libre SignIt web-browser extension translates selected word in French Sign Language via an elegant pop up so you learn sign language while reading online.
https://addons.mozilla.org/en-US/firefox/addon/lingua-libre-signit/
MIT License
11 stars 13 forks source link

State Refactoring, Module Import, and UI Enhancements #64

Closed kabir-afk closed 1 month ago

kabir-afk commented 1 month ago

The changes made in the commits are as follows:

  1. Commit on May 12, 2024:

    • Refactored the code to use the Chrome Storage API for setting the state. This indicates a fundamental change in how the state is managed within the application, shifting from potentially using different storage mechanisms to leveraging the Chrome Storage API for more consistent and integrated state management.
  2. Commits on May 14, 2024:

    • Fixed the successful import of the "banana" module and reused it's i18n statements.
    • Replaced the search UI icon so that it doesn't violate the CSP.

Screenshot (46) This is the error it used to throw earlier , instead of updating the CSP I tweaked the CSS for an easy fix.

I would not bulk commit this time so that it's easier to verify the changes unlike pre-selection period 😅

hugolpz commented 1 month ago

Comment: You replaced CSS inlined svg code for reference to svg files. It implies the addon to have access rights via Manifest.json to 2 resources :

Which, given web browsers' addon context and ubiquitous security measures I'm always a bit worry about those.

Ideally, your approach is more natural. If necessary, we have in mind this css inlined svg alternative.

Thank @kabir-afk for this PR !