search

lingua-libre / SignIt

🌻 Lingua Libre SignIt web-browser extension translates selected word in French Sign Language via an elegant pop up so you learn sign language while reading online.
https://addons.mozilla.org/en-US/firefox/addon/lingua-libre-signit/
MIT License
13 stars 13 forks source link

Refactor i18n Localization and Background Page Fetch #65

Closed kabir-afk closed 4 months ago

kabir-afk commented 4 months ago

Description: This Pull Request addresses the following changes:

  1. Fix: Resolved an issue with i18n localization in SignItCoreContent.js to ensure compatibility with both Chrome and Firefox. The issue was referenced earlier at #19 where relevant challenges faced are mentioned. While I did try passing banana as a parameter , and its values are certainly passed , the i18n functionality isn't imported...in my commit earlier emphasized on the same but things only worked in Chrome...now they do in FF as well
  2. Update: Updated the SVG icon URLs for previous, next, and search in popup.css for improved UI aesthetics.
  3. Refactor: Streamlined the code to fetch the background page efficiently for better performance.

Changes:

Commits:

  1. af51c9a - Fix issue with i18n localization in SignItCoreContent.js
  2. 92a23e1 - Update SVG icon URLs in popup.css
  3. 46339be - Refactor code to fetch the background page efficiently
kabir-afk commented 4 months ago

Thank for this code improvement.

I assume text is temporarily broken and therefore commented. 46339be#diff-2ce48ac6dbf8501b60a7bbeb4c05cbd8b5eead20f4566669b124ade52182387bR120-R126

Yea, well actually this.searchWidget relied on records inside _backgroundPage which dont work apparently , so I commented them out temporarily

hugolpz commented 4 months ago

Understood. Thank for the explainer.