lingua-libre / SignIt

🌻 Lingua Libre SignIt web-browser extension translates selected word in French Sign Language via an elegant pop up so you learn sign language while reading online.
https://addons.mozilla.org/en-US/firefox/addon/lingua-libre-signit/
MIT License
11 stars 13 forks source link

Refactor `SignItCoreContent` for browser compatibility & modal init fix #72

Closed kabir-afk closed 1 month ago

kabir-afk commented 1 month ago

Changes

  1. b9cf4f - Made a function to pass messages in order to adhere to DRY principle. Allows reusability while not cluttering the codebase and optimizes the message passing process.
  2. 6505f6 - Refactored the way SignItCoreContent.js received banana such that it is universal to both Chrome and FF.
  3. 557293 - Initialized modal every time when signit.hintIcon message was passed rather than calling it only when popup was undefined.

Description

kabir-afk commented 1 month ago

I forgot to mention that in background script I added extra regex to remove comma and other special characters inside getAvailableWord function