search

lingua-libre / SignIt

🌻 Lingua Libre SignIt web-browser extension translates selected word in French Sign Language via an elegant pop up so you learn sign language while reading online.
https://addons.mozilla.org/en-US/firefox/addon/lingua-libre-signit/
MIT License
11 stars 13 forks source link

Popup>Settings with persistent memory on all browsers #87

Open hugolpz opened 3 weeks ago

hugolpz commented 3 weeks ago

Insure that selection of settings options are saved into some persistent memory storage.

See also #56

kabir-afk commented 2 weeks ago

@hugolpz I wanted to confirm one thing ? I resolved it partially as mentioned in above referenced PR as I fixed how storeParam was being executed. But we'd still want the user's preferred setings to persist even if he opens a new tab or reloads the page right ?Because my solution works as long as service_worker is alive and that too for the current tab. They reset when reloaded or a new tab is opened. I would say it makes the settings tab functional , but partially.

hugolpz commented 2 weeks ago

@kabir-afk Correct. Ideally settings are persistent even if we close the current tab and open a new one. Or even when we close the browser and whole computer. I was so few months ago.

But I don't remember how I did it then (localStorage I believe), I'm not clear how you do it now, so I can't tell if it's still possible from your current/new approach.

kabir-afk commented 2 weeks ago

I'll see what I can do