Testing `browser.i18n` API

lingua-libre / SignIt

🌻 Lingua Libre SignIt web-browser extension translates selected word in French Sign Language via an elegant pop up so you learn sign language while reading online.

https://addons.mozilla.org/en-US/firefox/addon/lingua-libre-signit/

MIT License

13 stars 13 forks source link

Testing `browser.i18n` API #91

Closed kabir-afk closed 3 months ago

kabir-afk commented 3 months ago

Changes

4af82b - added target='_blank' so that speaker url opens in new tab
d29827 - replacing extensionName in 3197d1 to si_addon_title
6bc7b9 - replaced banana.i18n with browser.i18n.getMessage() as addressed in #86
Result

Scope	Chrome	Firefox
Popup > Settings	✔	✔
Popup > Browse > video gallery	✔	✔
Content script > modal > video gallery	✔	✔

NOTE: When talking about settings , changeUiLanguage function is not being talked about

kabir-afk commented 3 months ago

@kabir-afk : The manifest.json change wont work since these two messages do not exist in ./i18n/*.json files. Use messages which exist in ./i18n/*.json files :

"name": "__MSG_si_addon_title__"

"description": nothing for now, I will handle this later.

I have addressed the same in d29827 as well as mentioned in the PR above.

lingua-libre / SignIt

Testing `browser.i18n` API #91

Changes

Result