fix : i18n

[kabir-afk]

Changes Made

June 13

• refactor : storeParams now working properly - Used array destructuring to fetch the arguments properly. With this storeParam message now works properly and invokes the storeParam function inside sw.js and background-script.js . I think this addresses #87 . Although #56 still persists.
• chore: passing message to execute i18n natively inside sw/bg.js - This is the highlight of this PR. I figured it was better to pass messages from popup/other content scripts to execute banana.i18n directly inside sw.js/background-script.js and then send the response acccordingly. Pros and cons of what we were doing earlier vs now :

  • EARLIER [EDIT: Chrome native's browser.i18n API]

    • Pros :
    • It worked as expected and wasn't too asynchronous in nature, relied on local storage in the name of asynchronous nature.
    • Cons :
    • Verbosity changed depending on the context of usage : For example - SignItVideosGallery and SignItCoreContent. In both the files different implementations of the same functions exist.
    • Repetitve in nature : If some other content script or constructor function popped , we'd have to copy/paste it again in order to make it work.
    • Buggy UI : While changing UI language , Popup had to be toggled off/on in order to see the changes and similar had to be done for the modal. This might have been due to SignItCoreContent constructor not initializing timely , rather than a local storage issue. Although I am not sure why this occured as upon being passed with chosen arguements (user's preferred language ), it was logged correctly but rendered previous language.

  • NOW [EDIT: Wikimedia banana.i18n sent up and processed in sw.js/background.js]

    • Pros :
    • Authenticity: leverages the original library , hence maintaining the authenticity.
    • Message passing: only needs a message to execute.
    • Little to no verbosity: Unlike our own i18n , this works the same in all the contexts and we dont have to redefine it as per our preference every time.
    • Cons :
      • Requires an async environment: As we are passing messages , we are returned with a promise which needs to be resolved whenever the function is called. This can become problematic when working with constructors. This is dealt with in fix : implemented the same message passing functionality as in popup by using an async prototype function named init, although not the best workaround.
      • Irregualar html parsing: While the library banana.i18n addresses its own , if not added as html inside the script, will render the string as is.

With this #84 can be closed now.

• reverting to banana.i18n - Since we are now using banana.i18n , replacing browser.i18n API as well as its messages.
• fix : implemented the same message passing functionality as in popup - This tries to achieve the same , but since its a constructor , promises had to be resolved first inside an async prototype, then inserted separately inside it using jQuery DOM manipulation. The only issue is that whenever it is called init has to be invoked as shown in refactor : updated how SignItCoreContent() is called.
• refactor: implemented the same message passing i18n functionality - Same thing as earlier.

June 14

• refactor: used HTML instead of text for videosPanelNoVideoEmpty - As mentioned above in the cons, earlier when used .text() , rendered <br/> as is. But replacing it with .html() resolved it.
• storing banana and sourceMap no longer needed - we don't need to store this inside loadi18Localization now as we no longer rely on it.

[kabir-afk]

NOTE: Just in case you get HTTP Status Code 502 : Method not allowed. comment out the signLanguages = await getSignLanguagesWithVideos(); and records = await getAllRecords( signLanguage ); line in both sw.js and background-script.js. I haven't thoroughly tested the changes in FF, so please let me know if there are some discrepancies.

[hugolpz]

This is the highlight of this PR. I figured it was better to pass messages from popup/other content scripts to execute banana.i18n directly inside sw.js/background-script.js and then send the response acccordingly.

Thank @kabir-afk for figuring that out !