lingua-libre / SignIt

🌻 Lingua Libre SignIt web-browser extension translates selected word in French Sign Language via an elegant pop up so you learn sign language while reading online.
https://addons.mozilla.org/en-US/firefox/addon/lingua-libre-signit/
MIT License
11 stars 13 forks source link

feat : adding alarms API #97

Closed kabir-afk closed 1 week ago

kabir-afk commented 2 weeks ago

Changes

Whats actually happening is , whenver user selects the extension icon, along with getBackground command createAlarm function is triggered , which creates the alarm. Now our alarm isn't supposed to do anything , we don't have to do any periodic tasks like pinging the user to drink water after 1 min ,etc. We just have to wait for the state of the extension ot be ready and once it is ready , it will send a message to the popup which upon receving the message will initialize the UI, as mentioned in refactor: Initialize UI with respect to alarms API.

Ishan-Saini commented 1 week ago

LGTM

hugolpz commented 1 week ago

After the merge by Ishan, @kabir-afk added an additional commit.

@Ishan-Saini, How to proceed with it ? Any experience and best practices with such cases ?

kabir-afk commented 1 week ago

Didn't notice it earlier , pardon me for those changes. I had some conflicts with my master branch due to which it was populated with some unwanted past commits..hence to fix it I fetched and resetted my remote and local branch leading to this commit

hugolpz commented 1 week ago

@kabir-afk , can you ensure the master branch also get this https://github.com/kabir-afk/SignIt/commit/e97ed9365045314bd2979bd9ec8f397d259ee637 code ?