Closed kabir-afk closed 1 week ago
LGTM
After the merge by Ishan, @kabir-afk added an additional commit.
@Ishan-Saini, How to proceed with it ? Any experience and best practices with such cases ?
Didn't notice it earlier , pardon me for those changes. I had some conflicts with my master branch due to which it was populated with some unwanted past commits..hence to fix it I fetched and resetted my remote and local branch leading to this commit
@kabir-afk , can you ensure the master branch also get this https://github.com/kabir-afk/SignIt/commit/e97ed9365045314bd2979bd9ec8f397d259ee637 code ?
Changes
manifest.json
setTimeout
still works in persistent backgroundPage which we use for Firefox. So keeping it now for temporary testing purposes.