lingua-libre / SignIt

🌻 Lingua Libre SignIt web-browser extension translates selected word in French Sign Language via an elegant pop up so you learn sign language while reading online.
https://addons.mozilla.org/en-US/firefox/addon/lingua-libre-signit/
MIT License
11 stars 13 forks source link

Refactor/callbacks to promises #99

Closed kabir-afk closed 1 week ago

kabir-afk commented 1 week ago

Changes

As mentioned in docs , we had to replace extension methods which used callabacks with promises. This was the only code I could find which used a callback in extension API methods. Inside other methods , we have used promises to await their responses and then worked further ahead. Although I still encourage @hugolpz and @Ishan-Saini to go through the codebase and find if there is some method I missed.

With this we can close #98 .

hugolpz commented 1 week ago

Web API callback to promise migration table

image

Search in github code

Ishan-Saini commented 1 week ago

LGTM