linux-test-project / lcov

LCOV
GNU General Public License v2.0
867 stars 235 forks source link

Use orange instead of yellow for medium coverage #243

Closed JasperCraeghs closed 9 months ago

JasperCraeghs commented 9 months ago

Changed the color for medium coverage rate from yellow (#ffea20) to orange (#ffa500), as per documentation. I only changed the normal palette.

COLOR_13 is used by genhtml for all colors related to "med rate/coverage". Is this color configurable by the user or is this pull request the only way?

Perhaps the dark palette should receive a similar change. What do you think?

Signed-off-by: Jasper Craeghs jasper.craeghs@gmail.com

henry2cox commented 9 months ago

I think that users are likely to be used to seeing the current colour scheme and might be a bit surprised by a difference - even if it does not match the doc..so a better change is likely to fix the doc rather than to change the colour.

To override the palette, the currently supported idiom is to use your own CSS:

Note that this is potentially problematic in that we do periodically add something and so the CSS you laboriously created a year ago might not do everything you want today.
I'm not sure if that is an issue because I don't know how many people actually use the feature. (Very few, I suspect.)

Henry