minor fixups for `make check`

linux-test-project / lcov

LCOV

GNU General Public License v2.0

866 stars 234 forks source link

minor fixups for `make check` #270

Closed nega0 closed 4 months ago

nega0 commented 4 months ago

fix numeric compare in tests/common.mk
rename tests/lcov/format/Makfile → tests/lcov/format/Makefile
add test artifact to make clean
update .gitignore with new test artifacts

Signed-off-by: nega nega0@users.noreply.github.com

henry2cox commented 4 months ago

Thanks for the fixes. Good to know that somebody read the code and/or the tests :-)

Sorry to be pedantic - but could you add a 'signed off by' line? Or possibly it is there and I just can't see it. Same comment applies to the other pull request.

Henry

nega0 commented 4 months ago

sure. you squash merge, correct?

henry2cox commented 4 months ago

I believe so - but I fear that I am very far from an expert, so do not know for sure.

nega0 commented 4 months ago

ok. sign offs are in the PR descriptions and the individual commits.

henry2cox commented 4 months ago

thanks....should be visible in master now (??)