search

linuxserver / docker-tvheadend

GNU General Public License v3.0
168 stars 90 forks source link

tv_grab_url: set executable bit #212

Closed snh closed 1 year ago

snh commented 1 year ago

linuxserver.io

Description:

tv_grab_url, which was added in https://github.com/linuxserver/docker-tvheadend/pull/195, was missing the executable bit, preventing it from being usable.

Let me know if you think this warrants an entry in the change log and I'll happily update the PR.

Benefits of this PR and context:

Makes tv_grab_url usable.

How Has This Been Tested?

Performed a chmod +x within my container and restarted it to confirm that tv_grab_url now appeared in the UI and functioned as expected.

Source / References:

Closes https://github.com/linuxserver/docker-tvheadend/issues/196. Replaces https://github.com/linuxserver/docker-tvheadend/pull/206. /cc @Chris230291

thespad commented 1 year ago

PR is fine but I'm not going to merge until upstream fixes the issue that's currently breaking our builds.

Chris230291 commented 1 year ago

I gave up with these guys. They want to make everything so complicated. I just build my own custom image now with some other useful patches.

sdrik commented 1 year ago

FTBFS has been fixed upstream : https://github.com/tvheadend/tvheadend/commit/abcb0ea676e7b7e822be990aae7df1aa8ff5b990

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/tvheadend/abcb0ea6-pkg-b0aae1ce-pr-212/index.html https://ci-tests.linuxserver.io/lspipepr/tvheadend/abcb0ea6-pkg-b0aae1ce-pr-212/shellcheck-result.xml