search

liorgrossman / darkness

Dark Themes for Popular Websites
https://darkness.app
GNU General Public License v3.0
516 stars 752 forks source link

Port to Android? #158

Closed Andrew-J-Larson closed 5 years ago

Andrew-J-Larson commented 5 years ago

I'd love to see this working on Android... If this happens, I'll definitely look into buying the property features.

liorgrossman commented 5 years ago

As far as I know, browser extensions are not supported on Chrome for Android. Therefore, it's currently impossible to make Darkness work on Android.

Andrew-J-Larson commented 5 years ago

It's not impossible, at least for Firefox. I "fixed" my problem by installing the extension in Firefox Mobile. Might want to mention this somewhere on the main website for users that want to use Dark Reader on mobile.

On Thu, Mar 14, 2019, 9:49 AM Lior Grossman notifications@github.com wrote:

Closed #158 https://github.com/liorgrossman/darkness/issues/158.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/liorgrossman/darkness/issues/158#event-2204095867, or mute the thread https://github.com/notifications/unsubscribe-auth/ASuxdF9JKuC-KhsIx_GtLnFfseLm5BEpks5vWn2ogaJpZM4bxloQ .

liorgrossman commented 5 years ago

Ah, sorry. I mistakingly assumed you meant Chrome on mobile. Yes, the extension should theoretically work on Firefox Mobile, but unfortunately it was never tested. I hope it's fully functional.

Andrew-J-Larson commented 5 years ago

That's what I'm saying! Haha, it seems to be fully functional. So far it is working fine just like on the desktop. So, maybe include that mobile is indirectly supported when using Firefox Mobile on the main webpage somewhere? (that way others don't have to make issues on the Github).

On Thu, Mar 14, 2019 at 10:16 PM Lior Grossman notifications@github.com wrote:

Ah, sorry. I mistakingly assumed you meant Chrome on mobile. Yes, the extension should theoretically work on Firefox Mobile, but unfortunately it was never tested. I hope it's fully functional.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/liorgrossman/darkness/issues/158#issuecomment-473161788, or mute the thread https://github.com/notifications/unsubscribe-auth/ASuxdGEuz4qSh5RKFqcORFgQa1Hv5Vxoks5vWyyUgaJpZM4bxloQ .