search

liorgrossman / darkness

Dark Themes for Popular Websites
https://darkness.app
GNU General Public License v3.0
512 stars 754 forks source link

PayPal theme, wikipedia fixes and theme names. #164

Closed bartzalewski closed 5 years ago

bartzalewski commented 5 years ago

PayPal's bugs are written in websites/paypal.scss file.

liorgrossman commented 5 years ago

Thanks @reveur404 ! Awesome - a theme for PayPal! And so weird we didn't notice the theme names in the SASS.

Everything looks perfect. One comment though - can you explain why the change in packages.json is necessary?

bartzalewski commented 5 years ago

Thanks @reveur404 ! Awesome - a theme for PayPal! And so weird we didn't notice the theme names in the SASS.

Everything looks perfect. One comment though - can you explain why the change in packages.json is necessary?

Thank you!

So i had this error without my changes after trying to run npm start: AssertionError [ERR_ASSERTION]: Task function must be specified at Gulp.set [as _setTask]

But I changed it to default again and now everything works perfect, so that's unnecessary i guess.

bartzalewski commented 5 years ago

All of my changes:

Theme names:

Wikipedia:

When it comes to PayPal, there are a lot of language-based versions of the website and it's pretty hard to "darkify" all of them and make them all look perfect in the same time. Some classes and ids are overlapping each other so when I try to make a specific section of the page to black, it's black for example only on .com/us, /de, /ru, but on /pl, /es, /uk etc. it's white. So this is something that can't be fixed, but I know that most of the paypal's users won't reach those "bugged" pages. They will just simply go to the homepage, sign-in or sign-up, login to their account and that's it. These, and 90% more sites are looking perfect, so you won't see any white sections in there.

liorgrossman commented 5 years ago

Just saw the latest update, thanks! Great work on the PayPal theme. We never reach perfect 100% coverage for most modern websites, as they are complicated, but you gotta start somewhere :) Thanks for the other fixes as well Merged to master!