liorgrossman / darkness

Dark Themes for Popular Websites
https://darkness.app
GNU General Public License v3.0
512 stars 754 forks source link

Missing extension in Firefox Add-on Store #181

Closed absolutjdv closed 3 years ago

absolutjdv commented 5 years ago

Bug Information (visit the affected website → click the moon icon → "Send Feedback" → "Bug Report" → paste here)

Bug Description Please provide a clear description of what the bug or issue is.

Screenshots If necessary, add screenshots to help explain your problem.

theme1256 commented 5 years ago

Please elaborate on what you actually want, that is quite the bare "bug report"

hukitan commented 4 years ago

What he/she means, is that there's no extension in the Mozilla Add-on store as you can corroborate here https://addons.mozilla.org/en-US/firefox/addon/darkness-dark-themes/

liorgrossman commented 4 years ago

I can confirm. Darkness on Firefox has been disabled on the Mozilla addons store. Mozilla's addons store has new restrictions as to what is disallowed within extension code (interaction with DOM, remote scripts, etc.) I'm trying to figure out how to remedy it, as this would require many changes to the extension code facepalm

hukitan commented 4 years ago

Can I suggest making the .xpi file and publish on the website? Well, meanwhile something better appears

absolutjdv commented 4 years ago

Yes please, it would be awesome if Darkness on Firefox can be enabled again in the Mozilla addons store. I've tried other extensions like Dark Mode, Dark Reader etc., but none come close to Darkness. Love the way it changes my Google, Facebook experience. Kudos to the developers!

absolutjdv commented 4 years ago

Not yet... I'm also n00b and waiting for the extension

longnd commented 4 years ago

hi @absolutjdv could we have some updates regarding this issue?

absolutjdv commented 4 years ago

Yes the Darkness extension for Firefox Version 71.0 (64-bit) is missing.

absolutjdv commented 4 years ago

darkness-dark-themes

DanielContreras commented 4 years ago

It is missing, but if you temporarily (while, hopefully, this gets fixed) install the developer version and follow the instructions on the readme it does actually work. But it doesn't persist after exiting firefox due to it being a temporary plugin.

laicheungkee commented 4 years ago

This extension is still missing, of course I do understand the developers must know it ... I would like to get notification when it is back online again, so that I could get the Pro version as what I did on Chrome.

liorgrossman commented 4 years ago

Definitely aware of that! Trying to wrap my head around how to solve all the things the Mozilla review teams wants us to fix, this is really annoying. I'll update this issue as soon as we have progress on that front.

Gitoffthelawn commented 4 years ago

I don't know if this will help at all, but looking at the code of these two extensions may help you:

https://github.com/darkreader/darkreader https://github.com/timmyRS/Universal-Bypass

BTW, you may want to remove the invalid tag from this issue. :)

liorgrossman commented 4 years ago

Thanks! Indeed, I removed the "invalid" tag, this is definitely a valid issue

liorgrossman commented 3 years ago

Just an update here: Firefox add-ons store has added new restrictions a while ago as to what is disallowed within the add-on code (interaction with DOM, remote scripts, etc.), and has therefore disabled the Darkness add-on. Making Darkness comply with the Firefox add-ons store policy would require significant changes to the add-on code, so realistically, it is unlikely that we will re-publish it on the Firefox store. Firefox will still be supported if you install the extension locally, as described in the README, but not available in the add-on store. I have updated the README and the site to reflect that, but please let me know if I have missed anything.

Gitoffthelawn commented 3 years ago

@liorgrossman Thanks for your update!

What specific functions does Darkness have that are not allowed within the AMO store?

AFAIK, there are scores (perhaps hundreds) of popular extensions in the store that interact with the DOM.

Remote scripting would definitely be a no-no, for obvious reasons. I have never tried Darkness (it's on my list of extensions to try), so I haven't reviewed its code yet. Does it call remote scripts?

Anything else that would preclude Darkness from being in AMO?