lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
780 stars 35 forks source link

Replace Travis CI with Github Actions #110

Closed abdulhannanali closed 3 years ago

abdulhannanali commented 3 years ago

Description

This PR adds support for Github Actions as discussed in #109 . The workflow files are partially inspired by npq workflow file and partially by the previous .travis.yml as I didn't want to add any breaking changes.

Following is the summary of changes made:

Types of changes

Related Issue

109

Motivation and Context

Discussed in #109

How Has This Been Tested?

This has been partially tested, the workflows/test.yml workflow is tested in my fork but publish.yml workflow can only be tested once it's tried with the master branch.

Screenshots (if appropriate):

Checklist:

Cute Lil Hobbs

https://www.instagram.com/p/CNPy6qIpwoD/

lirantal commented 3 years ago

Lil Hobbs cute indeed :-)

Thanks for sending this @abdulhannanali Can we update the proposed code change here to actually have just one workflow file with all the jobs required and dependency between them? I've tried separate workflows before and there are some caveats with doing that.

abdulhannanali commented 3 years ago

@lirantal Yes I :heart: Lil Hobbs, especially this easter special shoot.

I have made the changes, it turns out if conditionals can also be applied on the job level and not just on run level, which eliminates the need for separate workflows anyways. I didn't know that before, so TIL something new. Thanks to you :smile:

lirantal commented 3 years ago

I think we also need to figure out how to run the test_locales setup from the original travis file. Let me have a bit of time set aside to review this and update here.

abdulhannanali commented 3 years ago

@lirantal I will add it. I was unable to comprehend what it was for and thought it was something Travis CI specific.

lirantal commented 3 years ago

@juanpicado can you further now PR the updates you were hoping to add with regards to caching, frozen lockfile and the test_locales from the original travis ci step? 🙏🏼