lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues

Apache License 2.0

780 stars 35 forks source link

fix(lockfile-lint-api): remove extra console.log in yarn.lock parsing #131

Closed julienw closed 2 years ago

julienw commented 2 years ago

Description

This removes a leftover from #126.

On my project that has a lot of dependencies, the list is pretty long and obscures the terminal output.

Thanks!

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

I didn't add an issue for this simple change.

Motivation and Context

This unwanted output to the console obscures the result.

How Has This Been Tested?

I ran yarn test and ran the code with changes on my project.

Screenshots (if appropriate):

before:

after:

Checklist:

[ ] I have updated the documentation (if required).
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.
[ ] I added a picture of a cute animal cause it's fun

I didn't add tests because that didn't seem useful for this change. Please tell me if you'd like me to look at adding some.

lirantal commented 2 years ago

Thanks for catching it and posting the quick fix @julienw 🙏🏼

codecov-commenter commented 2 years ago

Codecov Report

Merging #131 (24d67ea) into master (988347f) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   97.77%   97.75%   -0.02%     
==========================================
  Files          12       12              
  Lines         314      312       -2     
  Branches       67       67              
==========================================
- Hits          307      305       -2     
  Misses          7        7

Impacted Files	Coverage Δ
packages/lockfile-lint-api/src/ParseLockfile.js	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0b1828...24d67ea. Read the comment docs.