Closed yoavain closed 1 year ago
Base: 97.95% // Head: 97.95% // No change to project coverage :thumbsup:
Coverage data is based on head (
fcba2a9
) compared to base (a29d18b
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @yoavain 👏
Overall looks ok, but I was wondering if this won't cause an issue with the --empty-hostname
validator which on falsy value actually enables a stricter check? I'll check the code really quickly myself too but wanted to float that before merging.
So basically referring to this:
if (!isPassing) {
if (!packageResolvedURL.host && options && options.emptyHostname) {
this.debug(`detected empty hostname but allowing because emptyHostname is not false`)
Anyway, looks ok to me to merge but let me know if you think otherwise.
@lirantal
I think the change only affects the flags in supportedValidators
. empty-hostname
is not in that map
You're right, I see it passed in later as the option to the validators. Let's land it then.
Description
When adding a validator boolean flag to command line, the value was ignored, and the validator was activated even if its value was "false".
Types of changes
childProcess.spawn(cliExecPath, [...])
. Changed tochildProcess.spawn('node', [cliExecPath, ...])
Related Issue
https://github.com/lirantal/lockfile-lint/issues/145
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: