Closed brad-decker closed 1 year ago
This looks good to me. I'm happy if @naugtur wants to take a pass at it too. @brad-decker notice just really the explicit version change that you've updated which we need to revert (I committed to overwrite it so it's now ok).
Overall looks good to me. Let's give it a few days for more eyes before we merge.
Base: 97.95% // Head: 97.74% // Decreases project coverage by -0.21%
:warning:
Coverage data is based on head (
17539b3
) compared to base (8f7e4c7
). Patch coverage: 93.75% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Glad to see progress on #101! Happy to help with testing in https://github.com/blockprotocol/blockprotocol/pull/680, if needed 🚀
👋🏽 @brad-decker @naugtur @kumavis FYI that this has landed and you can apply any relevant updates on the metamask project/repo
Sorry for dropping the ball on this @lirantal but thank you for getting it landed. Much appreciated!
All good buddy. Thank you for opening this to begin with :-)
Description
Adds minimal support for yarn berry lockfiles. This is done by checking if the lockfile is yarn berry by referencing the initial key in the lockfile which will now be the __metadata key. If this occurs the parser normalizes the structure to match what is expected downstream. The changes that are here will result in users of this repo with yarn berry to change the way they configure allowed schemes (the resolved schemes are now things like 'npm:', 'patch:' and 'portal:'. All tests pass for the v1 lock file as well
Example use-case:
Types of changes
Related Issue
fixes #101
Motivation and Context
How Has This Been Tested?
A new lockfile using yarn berry was generated and added to fixtures and a new test was added to load and parse that lockfile
Screenshots (if appropriate):
Checklist: