lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
785 stars 35 forks source link

package.json: make the files to include stricter. #15

Closed XhmikosR closed 5 years ago

XhmikosR commented 5 years ago

Fixes #14

lockfile-lint:

C:\Users\xmr\Desktop\lockfile-lint\packages\lockfile-lint>npm pack --dry
npm notice
npm notice package: lockfile-lint@2.1.2
npm notice === Tarball Contents ===
npm notice 11.0kB LICENSE
npm notice 1.4kB  src/cli.js
npm notice 1.6kB  src/validators/index.js
npm notice 1.4kB  bin/lockfile-lint.js
npm notice 1.5kB  src/main.js
npm notice 4.7kB  package.json
npm notice 3.9kB  CHANGELOG.md
npm notice 6.5kB  README.md
npm notice === Tarball Details ===
npm notice name:          lockfile-lint
npm notice version:       2.1.2
npm notice filename:      lockfile-lint-2.1.2.tgz
npm notice package size:  9.2 kB
npm notice unpacked size: 32.0 kB
npm notice shasum:        5d148316e0aba93aa94b2e44330e6f026f801501
npm notice integrity:     sha512-swouwZKZdPnqe[...]vTCB/7xyo6DTQ==
npm notice total files:   8
npm notice
lockfile-lint-2.1.2.tgz

lockfile-lint-api:

C:\Users\xmr\Desktop\lockfile-lint\packages\lockfile-lint-api>npm pack --dry
npm notice
npm notice package: lockfile-lint-api@2.1.1
npm notice === Tarball Contents ===
npm notice 11.0kB LICENSE
npm notice 361B   index.js
npm notice 3.4kB  src/ParseLockfile.js
npm notice 1.4kB  src/validators/ValidateHost.js
npm notice 955B   src/validators/ValidateHttps.js
npm notice 1.1kB  src/validators/ValidateScheme.js
npm notice 4.5kB  package.json
npm notice 3.6kB  CHANGELOG.md
npm notice 5.3kB  README.md
npm notice === Tarball Details ===
npm notice name:          lockfile-lint-api
npm notice version:       2.1.1
npm notice filename:      lockfile-lint-api-2.1.1.tgz
npm notice package size:  9.4 kB
npm notice unpacked size: 31.6 kB
npm notice shasum:        07d9fec790dc0ee1c2dd0ad471d25695bff6dc71
npm notice integrity:     sha512-845Su4R4bYCXB[...]CeqWm7CXhTyMA==
npm notice total files:   9
npm notice
lockfile-lint-api-2.1.1.tgz
codecov-io commented 5 years ago

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files           8        8           
  Lines         137      137           
  Branches       20       20           
=======================================
  Hits          131      131           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76a5b3c...4324182. Read the comment docs.

XhmikosR commented 5 years ago

@lirantal: to clarify, I don't even know what hacktoberfest is (I assume some kind of a contest).

I contribute to open source the whole year, and I decided to make this change because we are about to add this on nodejs.org and I plan on adding your project on Bootstrap.

XhmikosR commented 5 years ago

So, I don't really care about such things myself, I just want to make things better for everyone when possible :)

lirantal commented 5 years ago

@XhmikosR that's wonderful to hear, thank you ❤️🤗

About hacktoberfest: https://hacktoberfest.digitalocean.com - I usually tag all PRs in October as belonging to that to remind me of these contributions, whether you're aware of it or not, shouldn't be an issue :)