search

lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
785 stars 35 forks source link

Use log symbols for easier to read output #21

Closed emimuresan closed 3 years ago

emimuresan commented 5 years ago

Is your feature request related to a problem? Please describe.

  1. More friendly and easier to read output.
  2. Also in case of no issues found, a success message should be printed - right now i don't see any message if all is ok.

Describe the solution you'd like Use something like: https://www.npmjs.com/package/log-symbols

Describe alternatives you've considered Alternative solution, styling the text: https://www.npmjs.com/package/ansi-colors, though i think the symbols are better.

lirantal commented 5 years ago

Sure we can try to spicy things up a bit. Did you have a particular format in mind for how errors would look like? I agree about having a success message too and formatting that is pretty straight-forward.

lirantal commented 4 years ago

@emimuresan happy to add it if you wanted to give a chance for a PR

XhmikosR commented 3 years ago

This should fix the Windows situation too where right now no symbols are shown, because Windows native CLI is inherently broken :)

emimuresan commented 3 years ago

Hi @XhmikosR @lirantal , i opened a PR for this (included Windows support). Pls review when you get the chance! 👍

lirantal commented 3 years ago

Thanks for getting back to this one! 👏🏼

glensc commented 2 years ago

a sysmbols typo appeared in changelog.md

lirantal commented 2 years ago

@glensc could you point me to what you're referring to?

glensc commented 2 years ago

@lirantal:

lirantal commented 2 years ago

OH I see. Thanks for flagging. I guess there's no other way of really fixing it except than editing the Changelog file which I think we can skip at this point.

glensc commented 2 years ago

yes. only changelog file could be fixed