lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
785 stars 35 forks source link

feat(emptyhostname): allow empty hostnames in lockfiles #26

Closed lirantal closed 4 years ago

lirantal commented 4 years ago

Description

BREAKING CHANGE: lockfile-lint-api internal method API has changed its function signature to allow receiving a value, and then an options object in a second argument.

Types of changes

Related Issue

Relevant issues:

Motivation and Context

Due to how npm install <github repo> works with implicitly referencing a github hostname without mentioning it, which causes a poor developer experience for users of lockfile-lint

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

codecov-io commented 4 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files          11       11           
  Lines         180      180           
  Branches       25       25           
=======================================
  Hits          175      175           
  Misses          5        5
Impacted Files Coverage Δ
packages/lockfile-lint/src/main.js 95.65% <ø> (ø) :arrow_up:
packages/lockfile-lint/src/cli.js 0% <ø> (ø) :arrow_up:
packages/lockfile-lint/src/validators/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abc71fa...ec4d934. Read the comment docs.