richsilv commented 4 years ago

Adds a note to the Validators table making it clear that URL-based validation will succeed for entries which lack a resolved field.

Description

Adds a note to the Validators table making it clear that URL-based validation will succeed for entries which lack a resolved field.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Issue has been fixed by https://github.com/lirantal/lockfile-lint/issues/43, but the change in behaviour warrants an update to the documentation.

How Has This Been Tested?

N/A

Screenshots (if appropriate):

Checklist:

[x] I have updated the documentation (if required).
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] I added a picture of a cute animal cause it's fun

^ one cute animal picture per week is probably sufficient!

codecov-io commented 4 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          11       11           
  Lines         189      189           
  Branches       29       29           
=======================================
  Hits          185      185           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b03a17...aa96d05. Read the comment docs.

lirantal commented 4 years ago

Looks good to me, thanks for the quick follow-up on this Richard 🙏

lirantal / lockfile-lint

docs(lockfile-lint-api): add note about validation for local packages #44