lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
785 stars 35 forks source link

docs(lockfile-lint-api): add note about validation for local packages #44

Closed richsilv closed 4 years ago

richsilv commented 4 years ago

Adds a note to the Validators table making it clear that URL-based validation will succeed for entries which lack a resolved field.

Description

Adds a note to the Validators table making it clear that URL-based validation will succeed for entries which lack a resolved field.

Types of changes

Related Issue

https://github.com/lirantal/lockfile-lint/issues/42

Motivation and Context

Issue has been fixed by https://github.com/lirantal/lockfile-lint/issues/43, but the change in behaviour warrants an update to the documentation.

How Has This Been Tested?

N/A

Screenshots (if appropriate):

Checklist:

^ one cute animal picture per week is probably sufficient!

codecov-io commented 4 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          11       11           
  Lines         189      189           
  Branches       29       29           
=======================================
  Hits          185      185           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b03a17...aa96d05. Read the comment docs.

lirantal commented 4 years ago

Looks good to me, thanks for the quick follow-up on this Richard 🙏