search

lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
781 stars 35 forks source link

invalid protocol when undefined #58

Closed travi closed 4 years ago

travi commented 4 years ago

Expected Behavior

before the new version published today, running lockfile-lint against my projects was passing.

Current Behavior

now seeing several projects failing with lots of failures similar to 

detected invalid protocol for package: abbrev@1.1.1-8f0b92d6fc7847f731964a4f3ab3b7c1e53edee5
     expected: https:
     actual: undefined

https://travis-ci.com/travi-org/matt.travi.org/builds/147288295#L340-L2012

not sure if this was intentional with recent changes, but seems unexpected.

Possible Solution

Steps to Reproduce (for bugs)

  1. Clone from https://github.com/travi-org/matt.travi.org
  2. git checkout greenkeeper/lockfile-lint-3.0.10
  3. nvm install
  4. npm install
  5. npm run lint:lockfile

Context

Greenkeeper PRs to several of my projects failed

Your Environment

sobolevn commented 4 years ago

Related: https://github.com/wemake-services/wemake-vue-template/pull/1594

fregante commented 4 years ago

I just did a clean of my project (latest deps and new package-lock) and still got this error: https://github.com/sindresorhus/refined-github/pull/2751

lirantal commented 4 years ago

thanks, looking into it 👁

lirantal commented 4 years ago

@fregante @travi thanks for opening the issue quickly, I fixed the regression with PR #59

fregante commented 4 years ago

I can confirm #59 works. Thank you for the quick fix!

lirantal commented 4 years ago

Thanks! 🙏

travi commented 4 years ago

fixed for me as well. thanks for the quick resolution :)