lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
781 stars 35 forks source link

fix(build): double quote globs in npm scripts #66

Closed XhmikosR closed 4 years ago

XhmikosR commented 4 years ago

Many shells don't support single quotes including Windows cmd

Description

Types of changes

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

XhmikosR commented 4 years ago

BTW I'm having trouble with tests on Windows, but I'll figure something out and provide a patch. I suspect is due to line endings.

lirantal commented 4 years ago

Cool, let me know.

codecov-io commented 4 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files          11       11           
  Lines         183      183           
  Branches       29       29           
=======================================
  Hits          174      174           
  Misses          8        8           
  Partials        1        1
Impacted Files Coverage Δ
packages/lockfile-lint/src/cli.js 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ece0a25...68b81a2. Read the comment docs.