XhmikosR commented 4 years ago

Description

switch to string.includes
improve usage of jest assertions

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

[ ] I have updated the documentation (if required).
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] I added a picture of a cute animal cause it's fun

@lirantal I can't test this being I'm on Windows and tests just fail for master too. :/

codecov-io commented 4 years ago

Codecov Report

Merging #68 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files          11       11           
  Lines         183      183           
  Branches       29       29           
=======================================
  Hits          174      174           
  Misses          8        8           
  Partials        1        1

Impacted Files	Coverage Δ
...lockfile-lint-api/src/validators/ValidateScheme.js	`100% <100%> (ø)`	:arrow_up:
...s/lockfile-lint-api/src/validators/ValidateHost.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e84bdb7...1972cca. Read the comment docs.

lirantal commented 4 years ago

Love it, thanks @XhmikosR ❤️

lirantal / lockfile-lint

chore: switch to `string.includes` #68