search

lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
781 stars 35 forks source link

fix(tests): use `path.join` when concatenating paths #70

Closed XhmikosR closed 4 years ago

XhmikosR commented 4 years ago

It doesn't fix the Windows issue but makes sense to me :)

codecov-io commented 4 years ago

Codecov Report

Merging #70 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files          11       11           
  Lines         183      183           
  Branches       29       29           
=======================================
  Hits          174      174           
  Misses          8        8           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a089214...25039b7. Read the comment docs.

XhmikosR commented 4 years ago

Let me rebase @lirantal

lirantal commented 4 years ago

Thanks! much cleaner and ready the work for true cross-platform (cough windows cough) ;-)