search

lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
781 stars 35 forks source link

PackageError module is not used. #78

Closed bolatovumar closed 4 years ago

bolatovumar commented 4 years ago

As the title says, PackageError module is defined but never used anywhere.

See here: https://github.com/lirantal/lockfile-lint/blob/master/packages/lockfile-lint-api/src/common/PackageError.js#L3

lirantal commented 4 years ago

Indeed, that's due to the refactor we did that swallowed errors (https://github.com/lirantal/lockfile-lint/blob/a089214722c2cc355bd6be602b7af475acf247a5/packages/lockfile-lint-api/src/validators/ValidateScheme.js#L42-----L43).

I think it's safe to remove for now and if we need in the future we can re-add it.

XhmikosR commented 4 years ago

@lirantal this can be also closed 🙂 (Address does not close the referenced issue 😛)

lirantal commented 4 years ago

Yes! oooof I really miss semantic-release for monorepos 🙃 Thanks!