lirantal / lockfile-lint

Lint an npm or yarn lockfile to analyze and detect security issues
Apache License 2.0
781 stars 35 forks source link

feat: add validation success console message #87

Closed bolatovumar closed 4 years ago

bolatovumar commented 4 years ago

Adds validation success message.

Types of changes

Related Issue

Close #76

Motivation and Context

Informs the user that everything is good so the user is not left wondering if the validation actually ran successfully.

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Screen Shot 2020-03-28 at 4 05 51 PM

Checklist:

codecov-io commented 4 years ago

Codecov Report

Merging #87 into master will increase coverage by 2.69%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   96.87%   99.56%   +2.69%     
==========================================
  Files          11       11              
  Lines         192      230      +38     
  Branches       31       40       +9     
==========================================
+ Hits          186      229      +43     
+ Misses          5        1       -4     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
packages/lockfile-lint/src/main.js 95.65% <0.00%> (ø)
packages/lockfile-lint-api/index.js 100.00% <0.00%> (ø)
packages/lockfile-lint/src/validators/index.js 100.00% <0.00%> (ø)
...s/lockfile-lint-api/src/validators/ValidateHost.js 100.00% <0.00%> (ø)
...kages/lockfile-lint-api/src/common/PackageError.js
...es/lockfile-lint-api/src/validators/ValidateUrl.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b481e80...dbb8321. Read the comment docs.

lirantal commented 4 years ago

Good stuff, thanks @bolatovumar

XhmikosR commented 4 years ago

FYI the emojis don't work on Windows default cmd @lirantal

lirantal commented 4 years ago

Thanks @XhmikosR. what does it look like?

XhmikosR commented 4 years ago

ll

lirantal commented 4 years ago

Gotcha. Feel like PRing a small one to remove the emoji?