lisarodenburg
commented
2 years ago Thanx for the feedback!
- forgot to remove one of the R-projects: oops!
- And good to hear that you cannot load the excel files. will change this in r scripts which i need to share in future
VivianWitjes
1. What project did you reproduce (include the link)?
-> https://github.com/lisarodenburg/course_test
2. Does the project have the following on it's GitHub repository?
3. What did you appreciate about the project's repository?
-> The repository includes an R project so no changes in directory have to be made manually. Also it is easy to find the scripts and data files.
4. Do you have any suggestions for improvement to the repository?
-> There are 2 R projects and it is not clear what the differences are and which should be used for what goal
5. Did you manage to run the project successfully?
6. Where did you have to give up reproducing this repository (if applicable)?
-> At loading the data. The error: "Error in sheets_fun(path) : function 'Rcpp_precious_remove' not provided by package 'Rcpp' " kept occuring. I am used to loading .csv instead of .xlsx
7. Did you have to go into the code?
8. If you looked at the code: what did you like?
-> Every step was clearly defined and well explained
9. If you looked at the code, what would be a single line of advice you want to pass on to it's author?
-> As I am used to work with .csv, it would be my advise to load data in this way, because my R always has issues with .xlsx files (but this is very peronal)
10. Any final comments to the author?
-> The script looks very understandable, unfortunately I couldn't load the data
11. Do you think the class will benefit from a live demo of the reproduction of this project? Why/what can we learn?
-> No, because it is a small issue at the start and therefore I could not reproduce, but this can be fixed easily I think