search

litespeedtech / ols1clk

One click installation of Open LiteSpeed
145 stars 59 forks source link

Make DB packages optional or skippable #60

Closed peixotorms closed 1 year ago

peixotorms commented 1 year ago

Hi,

Can you please modify the ols1clk script to have some sort of flag to skip installation of MySQL/MariaDB/Percona?

There are cases where we may want to setup OLS but skip installing the database server, for example, when using with a remote server like AWS RDS.

Thank you

Code-Egg commented 1 year ago

Hi, I think it's already supported, just run the command without WordPress installation. E.g. ./ols1clk.sh

peixotorms commented 1 year ago

Hi,

When I run for example:

./ols1clk.sh --adminpassword myadminuser --adminpassword myadminpass --email noreply@example.local --lsphp 80

I can confirm that it does not install a database server, thank you. However, it shows a default MariaDB version: https://i.imgur.com/lYgTzKj.png I think that you should remove it, as it "appears" to be about ready to install it.

Also regarding that info... the WebAdmin URL: is missing. Perhaps adding it as https://ipaddress:7080 would be better for completion. If you want to improve it further, customizing the port with --adminport would be even better (for security).

One last thing is that on Vultr specifically (didn't check others), new instances default with ufw installed and allowing with only ssh port open on Ubuntu 22.04.

I understand that we still need to manually open ports for any web server to work... but perhaps a quick check to see if ufw is installed and printing a small notice warning which ports need to be open for it to work, can be an improvement. Not very important, but good as improvement.

Thank you

Code-Egg commented 1 year ago

Ok, fixed the following.

  1. add --adminport
  2. fix MariaDB version display
  3. Add WebAdmin URL in display

Firewall detection may not easy, skip it for now.

peixotorms commented 1 year ago

Great, thank you for the changes.