search

ljnsn / cz-conventional-gitmoji

A commitizen plugin that combines gitmoji and conventional commits.
14 stars 3 forks source link

Add support for chore commit type #131

Closed donbignose closed 5 months ago

donbignose commented 7 months ago

While chore is not a type in cz, it seems to be used and recommended by conventional commits.

Would it be possible to add it in the mojis that you use? The pre-commit doesn't work for me with chore type commit.

ljnsn commented 7 months ago

Chore sounds like a good one to add, but there is no gitmoji for it. So I think if it's added, it should be opt-in via a config option.

What could be the emoji to become the chore gitmoji?

jjfantini commented 6 months ago

the wrench 🔧

ljnsn commented 6 months ago

That is already taken by config. Any of the official gitmojis are already mapped.

jjfantini commented 6 months ago

What about ⚒️, I cant find that anywhere

jjfantini commented 6 months ago

@donbignose I would recommend using cz_custommizealong with cz-conventional-gitmoji. This allows you to declare custom commit types that are parsed by the cz-conventional-gitmoji engine. You can overwrite any emoji for any type of commit that you'd like

ljnsn commented 6 months ago

What about 🧹 ? Quite fitting for a chore don't you think?

jjfantini commented 5 months ago

yeah! i think that is a great idea, would love to have that in the commit parser

ljnsn commented 5 months ago

I've added the chore type without any config option for now. I had already planned to add options to restrict types to conventional only, as well as some other configuration options, so it makes sense to add that together with an option for gitmoji only types. At the moment I don't have the time to do that though, so now it's already possible to use chore just like any of the other types.