ljnsn / cz-conventional-gitmoji

A commitizen plugin that combines gitmoji and conventional commits.
14 stars 2 forks source link

[BUG]: `cz_gitmoji` doesn't support bump #138

Closed jjfantini closed 3 months ago

jjfantini commented 6 months ago

I am trying to use cz-conventional-gitmoji in a Github Action, to bump my package version automatically.

I am met with this error: 'cz_gitmoji' rule does not support bump

Even if I run the command on the CLI with cz --name cz_gitmoji bump, I get the same error... 'cz_gitmoji' rule does not support bump

Screenshot 2024-03-06 090556

jjfantini commented 6 months ago

I am using the same workflow in my package as I am in this package. Please take a look and see the config.

I am wondering what the error is coming from? @ljnsn

ljnsn commented 5 months ago

Hey, I have recently set up another repo using cz_gitmoji (like pretty much all of them) and bumping is working fine. The bump config is the same as yours apart from the changelog_increment_filename: body.md, so I am sure it supports bumping.

The issue must be coming from the combination of using this package with some of the other customizations you're doing in your repo. I haven't really tested much with additional customizations. I'm happy to look into it, if you could provide a minimal reproducible example. Please set up the project with gz_gitmoji only first, make sure that it works and then add your customizations one by one. When you find the one that causes the issue, remove the other ones and post the config here.

jzazo commented 4 months ago

I think the conflicting config property is major_version_zero = true. When I comment this line out in my commitizen config, cz bump works, but not when left uncommented.

ljnsn commented 4 months ago

Thanks @jzazo! I'll have a look at what causes the issue with this setting.

kenibrewer commented 3 months ago

Just wanted to comment that I've run into this bug as well. Thanks for this great tool @ljnsn !

ljnsn commented 3 months ago

Should be fixed in the latest version, could one of you confirm?

jzazo commented 3 months ago

I think it's working! I added major_version_zero = true and it worked.

ljnsn commented 3 months ago

Thanks for checking, I'll close this then :slightly_smiling_face:

kenibrewer commented 3 months ago

Thanks a ton!

On Tue, May 21, 2024 at 16:32 ljnsn @.***> wrote:

Thanks for checking, I'll close this then 🙂

— Reply to this email directly, view it on GitHub https://github.com/ljnsn/cz-conventional-gitmoji/issues/138#issuecomment-2123394510, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFHAFPZ5CSX6VKORLOAWZDZDOVPBAVCNFSM6AAAAABEJD7C32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGM4TINJRGA . You are receiving this because you commented.Message ID: @.***>