lmiphay / gentoo.overlay

lmiphay gentoo overlay
4 stars 3 forks source link

app-misc/homeassistant-bin #2

Open rdnetto opened 6 years ago

rdnetto commented 6 years ago

This PR makes the following changes to the homeassistant-bin ebuild:

lmiphay commented 6 years ago

Thanks for the PR @rdnetto

The systemd unit and KEYWORDS changes both LGTM

I think the write bit change will break various ways homeassistant configures itself (which it persists itself to files in /etc/homeassistant) and e.g. things like the automation editor (https://www.home-assistant.io/docs/automation/editor/). It would be good to lock down these config files somehow, but I am not sure there is anyway around this?

At a later stage it might be nice to add systemctl stop/start or restart support to the included update-homeassistant script (installed from the filesdir) - just for consistency, but there is no requirement to use it.

I will also copy to the systemd unit file to the work-in-progress non-bin app-misc/homeassistent ebuild when I get back to it (to keep them in somewhat in sync).

lmiphay commented 6 years ago

For the 0.67.0 version bump, I cherry picked:

  1. 8ed4ad387425beacd2803d085f580aa3e7a246e3 Added systemd service
  2. bdb98d51909440eba2acbc3a59767b0c295ae143 Don't set KEYWORDS on 9999
lmiphay commented 6 years ago

For the 0.68.0 version bump, I:

  1. removed the unit file dependency on the openrc conf file (hardwired as per what is apparently best practice).
  2. moved the config directory location back into the openrc init script
  3. updated the gentoo readme a bit to mention openrc specific bits

I don't think any of the above should break running under systemd - let me know if did however...

Still todo:

  1. make the update script systemd aware
  2. consider moving the the config directory to /var/lib/homeassistant
  3. copy the unit file to the non-bin version work-in-progress