search

loganch / AutoIt-VSCode

AutoIt Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=Damien.autoit
MIT License
74 stars 25 forks source link

Questions regarding changes to getPaths() in ai_config #195

Closed Danp2 closed 1 year ago

Danp2 commented 1 year ago

https://github.com/loganch/AutoIt-VSCode/blame/c2a2d15696122d3475c6d90a6c616ae963fd6b5e/src/ai_config.js#L191

Isn't this redundant since the value of i was just obtained from conf.defaultPaths?

https://github.com/loganch/AutoIt-VSCode/blame/c2a2d15696122d3475c6d90a6c616ae963fd6b5e/src/ai_config.js#L200

This check appears to break the smartHelp feature.

@vanowm Thoughts?

vanowm commented 1 year ago

It should be confValue not defaultPaths

Danp2 commented 1 year ago

It should be confValue not defaultPaths

Ok... that appears to resolve the issue with smartHelp.

Also, I figured out the answer to my Object.hasOwn query on my own. 🙄