search

loic-sharma / Messages

A Laravel Bundle for the Swiftmailer library
GNU Lesser General Public License v3.0
39 stars 7 forks source link

Added namespace to the Message Class #23

Closed jotafurtado closed 11 years ago

jotafurtado commented 11 years ago

Hi there. I think you should put some Namespace on Message class. I already have a Message class on my project that handles alert messages and adding your bundle in my project makes Laravel a little messy.

This could happen with projects from other people and namespace will prevent it.

loic-sharma commented 11 years ago

As of right now, this would break everyone's code. Could you alias the class to Message, and add a config that enables/disables the alias?

Thanks!

jotafurtado commented 11 years ago

The problem is that I'm already using a alias to the other Message Class.

'Message' => 'Flare\Messagely', Mail' => 'Mail\Message'

And create more code to enable/disable the alias.... I think that's waste of lines. Its really a problem to add namespace right now, but you should think about it to implement this on the next major version.