lojban / cll

Complete Lojban Language Chunked
http://lojban.org/publications/cll/
Other
176 stars 49 forks source link

Support subscript tags in glosses #428

Closed gr-g closed 3 years ago

gr-g commented 3 years ago

This commit in geklojban-1.2.9 adds subscripts for place numbers: https://github.com/lojban/cll/commit/374ef24b74e4bdfc781bef797dd1366431b248fb However, subscripts inside glosses break the gloss alignment (they are treated as separate items). This change makes sure that subscripts inside glosses are treated appropriately.

lagleki commented 3 years ago

Will be merged to branch https://github.com/lojban/cll/commits/geklojban-1.2.12 Notice your pr has conflicts with at least geklojban-1.2.12, geklojban-1.2.11 in chapter 19 due to changes in pinyin transliteration.

lagleki commented 3 years ago

Since the pr is sent into dockbook-prince branch but explicitly mentions geklojban-1.2.9 I'm closing it.

gr-g commented 3 years ago

Thanks. I confirm that the commit was only intended to touch xml_preprocess.rb, but the pr was referring to docbook-prince and other commits from there might have been picked in the merge. Not strictly related, but it might be helpful to have a single "geklojban" branch for ongoing work (so that it can be tracked and pr made against it) and simply mark releases (1.2.12, 1.2.13, etc.) with tags.