search

lorenzo-rovigatti / tacoxDNA

A collection of tools for DNA modelling
http://tacoxdna.sissa.it/
GNU General Public License v3.0
17 stars 21 forks source link

Bugfix for issue #14 #22

Closed mckwxp closed 3 years ago

mckwxp commented 3 years ago

This commit fixed a bug which causes the cadnano converter to fail in some cadnano designs, such as that described in issue #14 . It has been tested on the cadnano file attached in issue #14 and also on some other designs which suffer from that problem.

lorenzo-rovigatti commented 3 years ago

Marco, thanks a lot for this. Have you tested this change with other designs that did not suffer from this problem to see whether the script doesn't break anything else?

mckwxp commented 3 years ago

Good point! I'll test it on a bunch of other designs in my library tomorrow.

mckwxp commented 3 years ago

FYI, this old issue on sourceforge is also related to this bug. This commit has fixed it but doesn't work for issue#14, but with this pull request, the part of the code in the linked commit will no longer be run.