lsils / mockturtle

C++ logic network library
MIT License
210 stars 139 forks source link

Attempt to fix compilation error while compiling with ClangCL on Windows #491

Closed marcelwa closed 3 years ago

marcelwa commented 3 years ago

First of all, thanks for the updates to the technology mapper! It works great but it, unfortunately, has some trouble compiling under Windows when compiling with the ClangCL toolset for Visual Studio. You can see the precise errors for instance here.

This commit tries to fix these issues by correcting some types and adding casts.

marcelwa commented 3 years ago

Can this PR be merged?

lee30sonia commented 3 years ago

@aletempiac Please merge it if it looks good, thanks!

aletempiac commented 3 years ago

Hi @marcelwa, I have just merged some fixes, and the compiling issue should be solved. Let me know

marcelwa commented 3 years ago

Awesome. I'll test it out and let you know!

marcelwa commented 3 years ago

Works perfectly fine :) Thanks a lot!