search

lsils / mockturtle

C++ logic network library
MIT License
210 stars 139 forks source link

Truth reader #539

Closed costamag closed 2 years ago

costamag commented 2 years ago

Parser for .truth files. It allows reading a multi-output truth table as a k-LUT network.

codecov-commenter commented 2 years ago

Codecov Report

Merging #539 (ec59c3e) into master (c4e50f0) will increase coverage by 0.24%. The diff coverage is 96.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
+ Coverage   82.52%   82.76%   +0.24%     
==========================================
  Files         146      149       +3     
  Lines       18207    18554     +347     
==========================================
+ Hits        15025    15356     +331     
- Misses       3182     3198      +16
Impacted Files Coverage Δ
include/mockturtle/networks/klut.hpp 92.25% <ø> (ø)
include/mockturtle/networks/storage.hpp 100.00% <ø> (+2.77%) :arrow_up:
include/mockturtle/algorithms/cover_to_graph.hpp 94.87% <94.87%> (ø)
include/mockturtle/networks/cover.hpp 96.23% <96.23%> (ø)
include/mockturtle/io/blif_reader.hpp 94.16% <96.42%> (-0.18%) :arrow_down:
include/mockturtle/io/truth_reader.hpp 100.00% <100.00%> (ø)
...nclude/mockturtle/algorithms/dsd_decomposition.hpp 87.32% <0.00%> (-4.23%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4e50f0...ec59c3e. Read the comment docs.

lee30sonia commented 2 years ago
  1. This PR mixes up code for different purposes (i.e. it includes the changes from #512)
  2. For changes to lorina, please make a PR there first.
  3. I'm not sure, actually, if Heinz would want to integrate a .truth parser in lorina. Maybe he will tell you what he thinks when you make a PR there.

You can, of course, keep the code and branch locally if it allows you to work on the contest. However, I will close the PR for now and we can discuss later whether we want to integrate it into mockturtle and/or lorina. In the end, the .truth file is not an efficient format and I don't think it's widely used.