Fix instances where register IO is being ignored.

lsils / mockturtle

C++ logic network library

MIT License

210 stars 139 forks source link

Fix instances where register IO is being ignored. #553

Closed yashton closed 2 years ago

yashton commented 2 years ago

This fixes several instances where only check is being made for PI, ignoring the other CI cases. Cleanup fails to handle registers at all. The two cleanup_dangling functions are split into separate copies for backwards compatibility.

hriener commented 2 years ago

Yes, we don't really consistently use the CI/CO API in mockturtle. Would be great to fix that.

Would it be possible to keep one cleanup_dangling function that is also backward-compatible? Having tests for the new functionality would be important too.

yashton commented 2 years ago

I'll reevaluate how cleanup could be done better with the previous signature. I just went for a brute force solution to get it working.

lee30sonia commented 2 years ago

Will be fixed by #567.