Closed rocallahan closed 2 weeks ago
I need to work out a Windows-compatible solution here.
Actually it looks like a lot of tests assume the current working directory is writable, so we should fix this another way.
Attention: Patch coverage is 50.00000%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 83.66%. Comparing base (
93a37e8
) to head (c6b66cf
). Report is 9 commits behind head on master.:exclamation: Current head c6b66cf differs from pull request most recent head 1db53c9
Please upload reports for the commit 1db53c9 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
include/mockturtle/io/serialize.hpp | 50.00% | 12 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@aletempiac, the coverage report is triggered by the branching added by @rocallahan. Testing all of them requires considering many cases, and from the code we can see that he is giving us a better handling of the files. Do you suggest to address the coverage issue or can we proceed with merging this PR?
Hmm, the tests pass for me.
Dear @rocallahan,this is great, thank you for the tests!
The current working directory may not be writable so it's better to write files explicitly to
/tmp
and clean them up afterward.