search

luciensadi / AwakeMUD

The Community Edition fork of the 'Awakened Worlds' Shadowrun 3 MUD codebase.
Other
55 stars 31 forks source link

First pass on vehicle repo #646

Closed UndeadNappist closed 2 years ago

UndeadNappist commented 2 years ago

First pass on vehicle repo.

Needs: Whatever the arbitrary nuyen value should be set at, locations on where to stick the defines for sanity's sake, adding flags.

UndeadNappist commented 2 years ago

Clarity on how the system is outlined:

  1. NPC and unowned vehicles are flagged when destroyed and given a timer.

  2. This timer only ticks down when not in another vehicle or garage.

  3. When the timer ticks to zero the flag is removed regardless of how things are handled.

  4. The vehicle is checked. If it's at zero value or less, or above a certain threshold in value, the vehicle is deleted. The upper threshold is going to be low, 5,000 nuyen (or less), so you can only get 500 nuyen worth vehicles here.

  5. If it's between those thresholds it's teleported to the junkyard instead. This is to force players to get the hyper-valuable vehicles immediately, while also having a repo/cleanup mechanic for them.

  6. Unowned/NPC flagged vehicles if above 0 value and below some arbitrary value (100k nuyen, or something), when fully repaired, swap their ownership to the repair person. This is to prevent people from getting super vehicles or other problematic things (although this will require building effort to support as it checks value).

Potentially adding a check to the junkyard workshop itself so it may only be used on vehicles below a certain price. This keeps it firmly in the hands of newbies, while also putting a barrier between players who can afford their own private workshops and such.

Anyway, this requires building work, discussion, and staff input, so for now, this is sitting with some framework and in an open draft.

UndeadNappist commented 2 years ago

I was discussing this and was prodded to outline the basic issues that I don't really have any answers for with this system as stated. The underlying issues with this system is not nuyen gain. Between the limitations on hauling vehicles, the amount of time it takes to do repairs, and implementing upper boundaries on the maximum value of a vehicle you can loot, it's fairly simple to restrain the amount of yen can farm.

Instead they are as follows:

  1. Vehicles are currently a moneysink. There is nowhere to get vehicles other than purchasing them in stores.
  2. Vehicles use a lot of special code that leads to higher overhead. This would be exacerbated if people started farming Americars and simply keeping them, using them en masse for storage or something equally ridiculous (although that last one is currently an issue anyhow, and probably would require adding a special 'save container' in vehicles to fix)
  3. There are certain uber or strangely statted vehicles that do not seem special, but would be destabilizing to allow falling into player hands. Forklifts are the immediate example that come to mind, but I am certain there are others.
  4. More overhead for builders going forwards as you have to be careful about future vehicles, or position them in places that are inaccessible for towing (on islands behind ferries/past bodyguards/in water, etc).

I'll probably do a smaller PR that uses some of this function for a cleanup procedure for slain NPC/unowned vehicles.