luciensadi / AwakeMUD

The Community Edition fork of the 'Awakened Worlds' Shadowrun 3 MUD codebase.
Other
55 stars 30 forks source link

Fix rounding sets down too early #719

Closed jdevnull closed 8 months ago

jdevnull commented 8 months ago

See: https://discord.com/channels/564618629467996170/1172680716274901042

If instead of rounding the ratings of armor sets down early, we can multiply all non-set armor ratings by 100 when figuring out layering. We then divide by 100 at the end.

luciensadi commented 8 months ago

I'm in favor of correcting errors in the code, but this one will have a measurable effect on balance (namely, increasing most PCs armor by up to 1/1 while not changing NPC armor levels). Is the buff to PC armor levels needed under the current balancing paradigm?

jdevnull commented 8 months ago

This doesn't affect PCs on the high end (qui 10+) since with the three big sets, it's better to replace both the body and under slots with non-set pieces, so the remaining set pieces total whole integers.

That said, it occurs to me that if we're keeping fractions, then there's a good argument that the qui requirement to avoid penalties should also not be rounded down. If Jexams' example is an elf, then they'd need to give up another set piece to avoid penalties.

Not sure if it'd be better to just close this PR or to also fix the qui requirement to match. Closing this leaves us at status quo, where the math is less intuitive for players trying to math out their outfits. Fixing the qui requirement to match would reduce the clothing options that lower qui characters can choose from while still avoiding bulkiness penalties.

luciensadi commented 8 months ago

Given that the qui requirement fix would negatively impact lower qui characters and potentially break existing builds, I think we can leave this one at status quo. Appreciate the PR though!