search

ludohenin / gulp-inline-ng2-template

Gulp plugin to inline HTML and CSS into Angular 2 component decorators
MIT License
126 stars 26 forks source link

Supporting promises as return types of style/template processor functions #35

Closed kinkoazc closed 8 years ago

kinkoazc commented 8 years ago

Hello,

Great work with this plugin! Currently I'm trying to process the css code with postcss(which has some async plugins), so the result will be a Promise, as opposed to a string. Supporting promises as return types would really help.

Thank you, k

ludohenin commented 8 years ago

@kinkoazc will see what I can do but that's not a small change.

ghost commented 8 years ago

@ludohenin I second @kinkoazc's appreciation for this great plugin. Works fantastically. I've also come across this issue today as well though using postcss which works predominantly in an async fashion.

Just checking if you have any plans for implementing this form of functionality in the short term?

Again, thanks for the work so far on this!

kinkoazc commented 8 years ago

@ianbelcher Hi! As a temporary solution I've created a PostCSS gulp task that runs before calling the gulp-inline-ng2-template one.

ludohenin commented 8 years ago

@kinkoazc @ianbelcher Working on it now.

ludohenin commented 8 years ago

Tagged and published as 2.0.0

kinkoazc commented 8 years ago

That's great! Thank you!

ghost commented 8 years ago

Thanks @ludohenin. Really appreciate the work!