search

ludohenin / gulp-inline-ng2-template

Gulp plugin to inline HTML and CSS into Angular 2 component decorators
MIT License
126 stars 26 forks source link

Fixes #44: Add Support for Backticks #61

Closed dawsontoth closed 8 years ago

dawsontoth commented 8 years ago

Calling it backticks in the tests instead of template strings seemed to make more sense, once I saw the quote related tests. (I've also seen them called "template literals"?)

This would fix the issue brought up here: https://github.com/ludohenin/gulp-inline-ng2-template/issues/44

dawsontoth commented 8 years ago

Well... the new test doesn't pass... Strange, because it does locally. I wonder if it's Node 0.12 related? I'm running 5.10.1.

ludohenin commented 8 years ago

Thanks for the PR! It is also working for me locally (node 6.4). Can you update the travis file and set node to 4.5 ?

ludohenin commented 8 years ago

Excellent, will merge and bump version tomorrow.

ludohenin commented 8 years ago

published as 3.0.1